(WIP) Separate sortable logic from Drag & Drop, and add generic Drag and Drop functionality #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for going forward with this! I wanted to do something like this for a long time, but as it is not really needed for my direct work I never had the time for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need the functionality of cyclejs-sortable, along with other generic Drag and Drop functionality, so I started refactoring this to make cyclejs-sortable implemented via more generic Drag and Drop interfaces.
I'm making this WIP pull request as a kind of notice-of-intent, so that any issues can be discussed beforehand.
Modeling after
react-dnd, I plan on adding:dragSourceanddropTargetwrappers, to allow for dragging between containersmakeSortablewould then internally be implemented by a combination of these interfacescanDroplike interfacedragPreview(ghosts) rendering